Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

[Ryan Baxter]

> On 2012-05-03 13:12:56, Ryan Baxter wrote:
> > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js,
> >  line 170
> > <https://reviews.apache.org/r/4976/diff/2/?file=106085#file106085line170>
> >
> >     The preferred experience now allows the service to suggest what 
> > experience, gadget or url, they want the container to show, we should 
> > probably honor that by default in this function, but provide a way for 
> > containers to override that functionality if they want.
> 
> Henry Saputra wrote:
>     I am not following this one. Are you suggesting if preferredExperience is 
> not set then Shindig should set some default values? The values for 
> preferredExperience will be used mostly by container before calling the 
> navigate function. Other than context I dont think the rest of 
> preferredExperience values are useful when actually rendering the gadget.

Nope that is not what I am saying, sorry for not being clear :)

Say we had this embedded experience

  {
    "gadget" : "http://www.example.com/embedded/gadget.xml";,
    "url" : "http://www.example.com/foo/bar.html";,
    "context" : {
      "title" : "Hello World",
      "id" : 123
    },
    "previewImage" : "http://www.example.com/embedded/123.png";,
    "preferredExperience" : {
      "target" : {
        "type" : "url"
      },
      "display" : {
        "type" : "link"
      }
  }

In this example there is both a gadget and url embedded experience provided by 
the service but the service has told us via the preferred experience that it 
prefers we render the url embedded experience over the gadget.  I assume this 
logic for which ee we are going to render in this case should go in 
osapi.container.ee.navigate.  By default if the service provides a target in 
the preferred experience I would expect the common container to honor that, but 
I image we should provide some way for containers to override this, so if 
containers want to always render the gadget no matter what, they can.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4976/#review7498
-----------------------------------------------------------


On 2012-05-03 19:13:28, Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4976/
> -----------------------------------------------------------
> 
> (Updated 2012-05-03 19:13:28)
> 
> 
> Review request for shindig and Ryan Baxter.
> 
> 
> Summary
> -------
> 
> Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec: 
> http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model 
> http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences
> 
> I remove the unneeded model for EmbeddedExperience because ActivityEntry uses 
> ExtendableBean, which act like a Map, to store opensocial and its extension 
> so there is no need to explicitly map embed or preferredExperience with 
> physical class:
> java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
> java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
> 
> 
> This addresses bug SHINDIG-1762.
>     https://issues.apache.org/jira/browse/SHINDIG-1762
> 
> 
> Diffs
> -----
> 
>   trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml 
> PRE-CREATION 
>   trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js 
> 1333227 
>   trunk/content/sampledata/canonicaldb.json 1333227 
>   trunk/features/src/main/javascript/features/embeddedexperiences/constant.js 
> 1333227 
>   
> trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
>  1333227 
>   
> trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js
>  1333227 
>   
> trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js
>  1333227 
>   
> trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js
>  1333227 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java
>  1333227 
>   
> trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java
>  1333227 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java
>  1333227 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json
>  1333227 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
>  1333227 
>   
> trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
>  1333227 
> 
> Diff: https://reviews.apache.org/r/4976/diff
> 
> 
> Testing
> -------
> 
> Updated the unit tests and modify EE sample gadget to test passing additional 
> context and respect preferredExperience display link text.
> 
> 
> Thanks,
> 
> Henry
> 
>