----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5345/#review8330 -----------------------------------------------------------
Ship it! Carrying over from the other review :) - Ryan Baxter On June 17, 2012, 4:44 a.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5345/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 4:44 a.m.) > > > Review request for shindig, Henry Saputra and Ryan Baxter. > > > Description > ------- > > Moving the review back to this review site. Old one here: > http://codereview.appspot.com/6306072/ > > Also, this patch has been cleaned up to get rid of conflicts on applying. > > > This addresses bug SHINDIG-1798. > https://issues.apache.org/jira/browse/SHINDIG-1798 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/json-xmltojson.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js > 1349992 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/5345/diff/ > > > Testing > ------- > > > Thanks, > > Dan Dumont > >
