> On June 19, 2012, 12:38 a.m., Ryan Baxter wrote: > > Dan instead of creating a whole new gadget to test with, could you modify > > the sample gadget which already leverages these APIs? > > https://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > > Dan Dumont wrote: > I just wanted a simple test gadget for this 1 use case. I didn't want to > clutter up the photolist example which, IMO, is a demo of a use case rather > than a test gadget.
Yeah but finding this test will be hard. People already go to the embedded experiences container for several things: 1.) To see how a container renders embedded experiences 2.) To see how to build an embedded experience gadget 3.) To see how embedded experiences can be placed in an activity stream 4.) To see how to open embedded experiences from a gadget via gadgets.views.openEmbeddedExperience Your gadget is off in another folder somewhere and people who are new to Shindig and are interested in EE will have a hard time finding it. I think exercising this use case in the existing gadget that already uses gadgets.views.openEmbeddedExperience keeps things more centralized and easier to find. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5345/#review8373 ----------------------------------------------------------- On June 18, 2012, 7:01 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5345/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 7:01 p.m.) > > > Review request for shindig, Henry Saputra and Ryan Baxter. > > > Description > ------- > > Moving the review back to this review site. Old one here: > http://codereview.appspot.com/6306072/ > > Also, this patch has been cleaned up to get rid of conflicts on applying. > > > This addresses bug SHINDIG-1798. > https://issues.apache.org/jira/browse/SHINDIG-1798 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js > 1351048 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/5345/diff/ > > > Testing > ------- > > > Thanks, > > Dan Dumont > >
