----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5345/ -----------------------------------------------------------
(Updated June 18, 2012, 7:01 p.m.) Review request for shindig, Henry Saputra and Ryan Baxter. Changes ------- Henry, thanks for the review. You're right I'm not sure why we weren't using that to begin with in the actions code either. I've updated the code to use that feature instead and removed the redundant code. Also included a test gadget. Description ------- Moving the review back to this review site. Old one here: http://codereview.appspot.com/6306072/ Also, this patch has been cleaned up to get rid of conflicts on applying. This addresses bug SHINDIG-1798. https://issues.apache.org/jira/browse/SHINDIG-1798 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/OpenViews-OpenEE.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/alltests.js 1351048 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/json-xmltojson/jsonxmltojson-test.js PRE-CREATION Diff: https://reviews.apache.org/r/5345/diff/ Testing ------- Thanks, Dan Dumont
