Hi, On 04.03.2010 14:46, Bertrand Delacretaz wrote: > Hi Carsten, > > On Tue, Mar 2, 2010 at 12:05 PM, Carsten Ziegeler <[email protected]> > wrote: >> Carsten Ziegeler wrote: >>> Carsten Ziegeler wrote: >>> ...the fake node is used inside >>> the StarResource to determine the resource type...which seems a little >>> bit strange to me... >>> >> In fact this causes for trouble as we pass the fake node to possibly >> registered jcr resource type providers. As soon as they call any method >> other >> the two supported methods of the fake node, we might get NPE's and whatnot. >> >> So I strongly suggest we remove this... > > This broke the espblog sample, and a number of other samples (in blog > posts, presentations etc) where we need to have a resource type for > URLs like /content/foo/*.html - I have reopened SLING-1420, can you > have a look?
The only reason IIRC to have the FakeNode etc. was to be able to use the JcrResourceTypeProvider to try to find a resource type for the resource and that this one uses a JCR Node to find a type. Maybe we have to fix this to take a Resource (the path provided by the resource is all the PathBasedResourceTypeProvider cares about anyway). WDYT ? Regards Felix
