cmrockwell commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528773456
##########
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.sling.junit.rules;
+package org.apache.sling.junit;
Review comment:
At first I tried keeping it under the rules package as public, but it
didn't seem to work. Maybe it was my mistake, but when I moved it up, my IDE
found it. I can try moving it under `org.apache.sling.junit.impl` if we are OK
with it being public. (I don't see why this helper can't be public).. But if
it should be protected, then I think it needs to be parent of sub-packages that
need to use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
