jsedding commented on a change in pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r528798628
##########
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.sling.junit.rules;
+package org.apache.sling.junit;
Review comment:
I have no problem with it being public. But I would prefer not to export
it (as in OSGi's Export-Package). I.e. it should not be official API but
instead remain an implementation detail. That's why I suggest the `impl`
package, because - by convention - it is not exported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
