cmrockwell commented on a change in pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-junit-core/pull/5#discussion_r529025065



##########
File path: src/main/java/org/apache/sling/junit/annotations/TestReference.java
##########
@@ -39,6 +38,12 @@
      */
     String name() default "";
 
+    /**
+     * LDAP-style filter for targeting a specific reference implementation
+     *
+     * @return the local name of the reference ("" by default)
+     */
+    String filter() default "";

Review comment:
       Yes. This is was done.

##########
File path: src/main/java/org/apache/sling/junit/ServiceGetter.java
##########
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.sling.junit.rules;
+package org.apache.sling.junit;

Review comment:
       Yes. This is was done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to