kwin commented on a change in pull request #25:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646146539
##########
File path:
src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java
##########
@@ -43,8 +44,20 @@
/**
* Shutdown the provider.
+ * @deprecated Use {@link #close()} instead.
*/
- void shutdown();
+ @Deprecated
+ default void shutdown() {
+
Review comment:
The idea is that provider implementations rather implement `close()`
instead of `shutdown()` to be able to propagate IOExceptions. Having two
different methods for shutting down and only the suboptimal signature
(`shutdown()`) as mandatory implementation feels wrong. With regards to no
shutdown/close method being mandatory I think this totally fine, as not every
artifact provider necessarily needs to do clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
