kwin commented on a change in pull request #25:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646435669
##########
File path:
src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java
##########
@@ -43,8 +44,20 @@
/**
* Shutdown the provider.
+ * @deprecated Use {@link #close()} instead.
*/
- void shutdown();
+ @Deprecated
+ default void shutdown() {
+
Review comment:
All you said is true, but my argument was "To log all those places
centrally, the exceptions should hit the manager.". Do you disagree with that?
Just to clarify: I want to get rid of
https://github.com/apache/sling-org-apache-sling-feature/blob/3d6749494d3b5cc180aed627e207509061ad0be0/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManager.java#L371
and let the exception bubble up to the caller. In the case of a Maven plugin
you should probably log with something or even fail the build in case the clean
fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
