kwin commented on a change in pull request #25:
URL:
https://github.com/apache/sling-org-apache-sling-feature/pull/25#discussion_r646407428
##########
File path:
src/main/java/org/apache/sling/feature/io/artifacts/spi/ArtifactProvider.java
##########
@@ -43,8 +44,20 @@
/**
* Shutdown the provider.
+ * @deprecated Use {@link #close()} instead.
*/
- void shutdown();
+ @Deprecated
+ default void shutdown() {
+
Review comment:
> With introducing close() to both, the provider and the manager, you
create this new situation where the provider now can throw on close - which
then needs to be handled by the manager.
AM had a close() method before this PR. So it may have thrown IOExceptions
already there. The only change right now is that providers (instead of just
logging with their own logging framework) propagate their exception to the
manager. Although this doesn't matter that much if you only think about the
Default provider, it may make a difference for 3rd party providers. To log all
those places centrally, the exceptions should hit the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
