joerghoh commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#issuecomment-876369106
@kwin: The RequestProgressTracker already contains a ton of timing information which can help you to pinpoint performance problems in individual filters, JSPs or HTL snippets. Of course its capabilities are limited, not every functinoality writes timing information there. I agree that we should have a more sophisticated framework which should allow us to get better timing information from relevant pieces of the stack without to instrument each and every functionality. But I don't see any trace of such a thing yet, not to speak of actual working code. Regarding the noise in the logfiles created by this functionality. I tested it with AEM, and I found 4 warnings (for 4 distinct BVPs) once on startup, but that's it. The trace logging showed that the subsequent calls to ``addBindings()`` took 3-6 microseconds. So it's unlikely that the logs are filled with noise. And the root cause of the problem is that the LayzBindings are not used consistently (which compute the variable only if used), but there are Bindings out there, which compute these values irrespective if they are used or not. Changing that code is problematic, if it's outside of your individual reach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
