joerghoh commented on a change in pull request #8:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#discussion_r682387841
##########
File path:
src/main/java/org/apache/sling/scripting/core/impl/DefaultSlingScript.java
##########
@@ -732,7 +735,16 @@ Bindings verifySlingBindings(final SlingBindings
slingBindings) throws IOExcepti
ProtectedBindings protectedBindings = new
ProtectedBindings(bindings, protectedKeys);
for (BindingsValuesProvider provider : bindingsValuesProviders) {
+ long start = System.nanoTime();
provider.addBindings(protectedBindings);
+ long stop = System.nanoTime();
+ LOGGER.trace("Invoking addBindings() of {} took {}
nanoseconds",
+ provider.getClass().getName(), stop-start);
+ if (stop-start > WARN_LIMIT_FOR_BVP_NANOS) {
+ LOGGER.info("Adding the bindings of {} took {}
microseconds; "
Review comment:
implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
