bdelacretaz commented on a change in pull request #8:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/8#discussion_r681561784
##########
File path:
src/main/java/org/apache/sling/scripting/core/impl/bundled/ScriptContextProvider.java
##########
@@ -105,7 +110,16 @@ public ExecutableContext
prepareScriptContext(SlingHttpServletRequest request, S
ProtectedBindings protectedBindings = new ProtectedBindings(bindings,
PROTECTED_BINDINGS);
for (BindingsValuesProvider bindingsValuesProvider :
bvpTracker.getBindingsValuesProviders(scriptEngine.getFactory(),
BindingsValuesProvider.DEFAULT_CONTEXT)) {
+ long start = System.nanoTime();
bindingsValuesProvider.addBindings(protectedBindings);
+ long stop = System.nanoTime();
+ LOG.trace("Invoking addBindings() of {} took {} nanoseconds",
+ bindingsValuesProvider.getClass().getName(), stop-start);
+ if ((stop-start) > WARN_LIMIT_FOR_BVP_NANOS) {
+ LOG.info("Adding the bindings of {} took {} microseconds;"
Review comment:
same nitpick as above, "which is above..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
