kwin commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673040172
##########
File path:
src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtension.java
##########
@@ -77,12 +81,14 @@ public Object call(final RenderContext renderContext,
Object... arguments) {
if (hasPlaceHolders) {
return getFormattedString(runtimeObjectModel, source,
formatObject);
}
+
try {
- // somebody will hate me for this
- new SimpleDateFormat(source);
+ // try to parse as DateTimeFormatter
Review comment:
The question is rather under which circumstances do you end in this area
as there are 4 return statements before this line (which IMHO cover all
configuration options...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
