Buuhuu commented on a change in pull request #11:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11#discussion_r673695624
##########
File path:
src/main/java/org/apache/sling/scripting/sightly/impl/engine/extension/FormatFilterExtension.java
##########
@@ -77,12 +81,14 @@ public Object call(final RenderContext renderContext,
Object... arguments) {
if (hasPlaceHolders) {
return getFormattedString(runtimeObjectModel, source,
formatObject);
}
+
try {
- // somebody will hate me for this
- new SimpleDateFormat(source);
+ // try to parse as DateTimeFormatter
Review comment:
But only for the condition that the `format` option is not one of `Date`
or `Calendar` (... a date according to
`org.apache.sling.scripting.sightly.render.RuntimeObjectModel#isDate`), in
which case the `getDateFormattedString()` always returns null
https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/11/commits/7e43ff55a4d27c89a35fa0041f9b97534881e093
I cannot find anything in the spec about this behaviour but it seems
reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
