[
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434420#comment-17434420
]
Radu Cotescu commented on SLING-10871:
--------------------------------------
There are a few more things that we need before this can completely replace the
utilities we had in Sling Servlet Helpers:
* the parameter map from
{{org.apache.sling.api.request.builder.impl.SlingHttpServletRequestImpl}}
should accept null values (sometimes for example the servlet name is not
available and this would lead to a NPE with the current implementation, based
on a dictionary)
*
{{org.apache.sling.api.request.builder.SlingHttpServletRequestBuilder#withParameters}}
should allow sending a {{null}} value, so that clients can still use the fluid
API, rather than perform null checks in the middle of the calls to the
{{Builder}}
* the request suffix should be customisable as well
I'll send a PR soon to improve these things.
> Add builder API for request/resource objects
> --------------------------------------------
>
> Key: SLING-10871
> URL: https://issues.apache.org/jira/browse/SLING-10871
> Project: Sling
> Issue Type: New Feature
> Components: API
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Priority: Major
> Fix For: API 2.24.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As discussed in SLING-10840 and in [1] we should a builder api for Sling http
> servlet request/response objects which do not have a real request/response
> as a backing
> [1]
> https://lists.apache.org/thread.html/r7c66bcfb66b30f801f6e3a17d42b437cfeca7f233d240d965f471dfd%40%3Cdev.sling.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
