[ 
https://issues.apache.org/jira/browse/SLING-10871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434828#comment-17434828
 ] 

Georg Henzler commented on SLING-10871:
---------------------------------------

[~cziegeler] Just came across 
[RequestPathInfoImpl|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/request/builder/impl/RequestPathInfoImpl.java]
 that is already merged (but not released), shouldn't we use 
[SlingUri|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/uri/SlingUri.java]
 that implements RequestPathInfo as well instead to avoid duplicate code? 
[SlingHttpServletRequestBuilder|https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/request/builder/SlingHttpServletRequestBuilder.java]
 would not have to change (it's simplifying the impl only, it could provide the 
method {{withSlingUri}} but maybe it's not clear then what happens in case a 
URI with a host is used)

> Add builder API for request/resource objects
> --------------------------------------------
>
>                 Key: SLING-10871
>                 URL: https://issues.apache.org/jira/browse/SLING-10871
>             Project: Sling
>          Issue Type: New Feature
>          Components: API
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: API 2.24.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> As discussed in SLING-10840 and in [1] we should a builder api for Sling http 
> servlet request/response objects which do not have a real request/response  
> as a backing
> [1] 
> https://lists.apache.org/thread.html/r7c66bcfb66b30f801f6e3a17d42b437cfeca7f233d240d965f471dfd%40%3Cdev.sling.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to