kwin commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/10#discussion_r749465702
##########
File path:
core/src/test/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtilTest.java
##########
@@ -100,7 +100,6 @@ public void testService3() {
List<Map<String, Object>> reference3Configs =
service3.getReference3Configs();
assertEquals(1, reference3Configs.size());
- assertEquals(200,
reference3Configs.get(0).get(Constants.SERVICE_RANKING));
Review comment:
That was a deliberate change.
`MockOsgi.newBundleContext().registerService(...)` must not consider metadata
or ConfigAdmin data to be in line with regular OSGi Containers. This call is
defined by the framework
(http://docs.osgi.org/specification/osgi.core/7.0.0/framework.service.html#framework.service.registeringservices)
and does not have any relation/dependency on any Compendium Chapters (like
http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html,
http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.cm.html or
http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html).
What makes you think that component descriptions
(http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#d0e38089),
Meta type resource
(http://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html#i1504250)
or configAdmin are relevant in this context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
