stefanseifert commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/10#discussion_r750149970
##########
File path:
core/src/main/java/org/apache/sling/testing/mock/osgi/MapMergeUtil.java
##########
@@ -98,6 +104,9 @@ private MapMergeUtil() {
mergedProperties.putAll(properties);
}
+ // add non overwritable properties
+ mergedProperties.put(ComponentConstants.COMPONENT_NAME,
targetClass.getName());
Review comment:
ah, was not aware of this. this goes a bit along with the discussion
above - if we want just apply the DS magic everyhwere or try to be super strict
and make a distinction (which may not be obvious for most of the mock users).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
