stefanseifert commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/10#discussion_r750149077
##########
File path:
core/src/test/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtilTest.java
##########
@@ -100,7 +100,6 @@ public void testService3() {
List<Map<String, Object>> reference3Configs =
service3.getReference3Configs();
assertEquals(1, reference3Configs.size());
- assertEquals(200,
reference3Configs.get(0).get(Constants.SERVICE_RANKING));
Review comment:
we currently do not have that clear distinction if a service in osgi
mock is registered via DS with all it's metadata magic or not. it may be there
is a test code out there that expects this metadata detection "just works" on
whatever way you register the component in the mock context. this would be a
breaking change then, although formally correct, leaving people who update to
latest version of mocks wondering why it's not working any longer. so i'm
wondering if it would do harm if we keep it as it was before - applying the DS
magic everywhere, even if only BundleContext.registerService is called.
if we decide differently, we should create a separate ticket and PR for this
change and document it properly, no one would expect such a change in a ticket
which adds support for those two new properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
