kwin commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/10#discussion_r750343215
##########
File path:
core/src/test/java/org/apache/sling/testing/mock/osgi/OsgiServiceUtilTest.java
##########
@@ -100,7 +100,6 @@ public void testService3() {
List<Map<String, Object>> reference3Configs =
service3.getReference3Configs();
assertEquals(1, reference3Configs.size());
- assertEquals(200,
reference3Configs.get(0).get(Constants.SERVICE_RANKING));
Review comment:
> if we decide differently, we should create a separate ticket and PR
for this change and document it properly, no one would expect such a change in
a ticket which adds support for those two new properties.
Agree, I created https://issues.apache.org/jira/browse/SLING-10922 and will
prepare a PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
