stefanseifert commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757794552
##########
File path: pom.xml
##########
@@ -180,7 +167,7 @@
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<!--
- embed all jackrabbit artifacts to prevent classpath
clashes
+ embed all jackrabbit artifacts, to prevent classpath
clashes
Review comment:
when using in combination with wcm.io aem-dependencies or
aem-cloud-depencies the oak.version does not matter - the version for oak-jcr
from the aem-dependencies always "wins" over the transitive dependency,
regardless in which order this is put here. that means this artifact can only
be used with AEMaaCS, not any AEM 6.5 dependencies (even AEM 6.5.11 is only at
1.22.9, not even at 1.26 which you marked as minimum for java 14+). that's
probably ok, but we have to be aware of it that lot of users will not be able
to use it, esp. not if the "by default" just want to update to latest version
of this test dependency.
i'm not sure if such a hard check for matching version is the best solution?
probably better check for same or newer? it might be ok if sling-mock-oak is
e.g. at oak 1.40 and oak-jcr from a future aem-cloud-dependencies is at 1.42 or
later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
