stefanseifert commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757795447
##########
File path: pom.xml
##########
@@ -67,27 +67,14 @@
<artifactId>org.apache.sling.testing.sling-mock.core</artifactId>
<version>${sling-mock.version}</version>
<scope>provided</scope>
- <exclusions>
- <exclusion>
- <groupId>org.apache.jackrabbit</groupId>
- <artifactId>jackrabbit-api</artifactId>
- </exclusion>
- </exclusions>
</dependency>
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.testing.sling-mock.core</artifactId>
<version>${sling-mock.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
- <exclusions>
Review comment:
my goal was that sling-mock itself is fully backwards compatible to AEM
6.4.0, which is 1.8.2. luckily enough it was no problem to use a newer version
of sling-mock-oak e.g. with oak 1.16.0 with having both API jackrabbit-api and
oak-jackrabbit-api in the classpath. that does no longer work with the version
from this PR due to the hard check we currently have.
i think i exclude it here to have the rest run without it, but when using it
together with sling-mock or aem-mock its there again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
