stefanseifert commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r758151463
##########
File path: pom.xml
##########
@@ -180,7 +167,7 @@
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<!--
- embed all jackrabbit artifacts to prevent classpath
clashes
+ embed all jackrabbit artifacts, to prevent classpath
clashes
Review comment:
there is an indirect dependency in sling mock (which also depends on
oak-jcr) - it comes from JcrResourceProvider, which uses OakEventFilter
internally. if you completely remove the oak-jcr dependencies from sling-mock
it compiles, but the unit tests do not run.
i'm not sure if we create problems removing the oak-jcr dependency from
aem-mock for use cases, where you are using aem-mock+sling mock and a latest
version of aem-dependencies, but not sling-mock-oak. will do a few test runs in
that combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
