kwin commented on code in PR #143:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929765408
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/SlingInitialContentBundleEntryMetaDataCollector.java:
##########
@@ -138,6 +141,11 @@ private void extractFile(JarEntry jarEntry,
JarOutputStream bundleOutput) throws
SlingInitialContentBundleEntryMetaData bundleEntry =
createSlingInitialContentBundleEntry(context, targetFile);
collectedSlingInitialContentBundleEntries.add(bundleEntry);
+ } else if (jarEntry.getName().endsWith(".cnd")) {
Review Comment:
IMHO only those cnd files referenced in the manifest are considered in Sling
Initial Content
(https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#node-type-and-namespace-definitions-cnd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
