kwin commented on code in PR #143:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929848527
##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentExtractContext.java:
##########
@@ -117,4 +120,13 @@ public JcrNamespaceRegistry getNamespaceRegistry() {
public List<PathEntry> getPathEntryList() {
return new ArrayList<>(pathEntryList);
}
+
+ @NotNull
+ public boolean isSlingNodeTypesEntry(@NotNull JarEntry jarEntry) {
+ if(slingNodeTypes == null){
+ return false;
+ }
+
+ return jarEntry.getName().equals(slingNodeTypes);
Review Comment:
This is potentially a comma separated list. Also a unit test/IT covering
this would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
