[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #143: SLING-11497 - convert all cnd files to repoinit statements

[GitBox]

kwin commented on code in PR #143:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/143#discussion_r929850216


##########
src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/BundleSlingInitialContentJarEntryExtractor.java:
##########
@@ -109,12 +109,6 @@ void extractAndAddToAssembler(@NotNull 
BundleSlingInitialContentExtractContext c
                     throw new IOException("Can not convert " + file + " to 
enhanced DocView format", e);
                 }
 
-                // remap CND files to make sure they are picked up by the 
NodeTypesEntryHandler
-                if 
(context.getNamespaceRegistry().getRegisteredCndSystemIds().contains(file.getName()))
 {
-                    contentPackageEntryPath = "/META-INF/vault/" + 
Text.getName(file.getName()) + ".cnd";

Review Comment:
   Why was the approach to convert to cnd files in a package discarded?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org