[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626674#comment-17626674 ]
Robert Munteanu commented on SLING-11507: ----------------------------------------- Created a Draft PR that shows how this can look - https://github.com/apache/sling-org-apache-sling-models-api/pull/8 . Still draft since I would like to add some automated tests and ensure that we catch all the fault scenarios. > Field injection should not inject static fields > ----------------------------------------------- > > Key: SLING-11507 > URL: https://issues.apache.org/jira/browse/SLING-11507 > Project: Sling > Issue Type: Task > Components: Sling Models > Affects Versions: Models Impl 1.4.14 > Reporter: Joerg Hoh > Priority: Major > Fix For: Sling Models Implementation 1.5 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently this injection works: > {noformat} > @SlingObject > private static ResourceResolver resourceResolver; > {noformat} > but it should not. Sling Models are Pojos and injection must never inject > into static fields. Instead it should throw an exception and an error message > indicating the problem (another option would be to refuse the injection with > a proper error message). -- This message was sent by Atlassian Jira (v8.20.10#820010)