[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628266#comment-17628266
]
Robert Munteanu commented on SLING-11507:
-----------------------------------------
Ok, so the approach seems to be something like:
- scan for classes annotated with "Model"
- for each class, check if static fields or static methods are annotated with
any annotation supported by Sling models
- if any such field/method is found, error out
It should be possible to set up a couple of smoke tests using the
maven-invoker-plugin and we should be good to go.
I won't have time to "productise" this in the short term unfortunately
> Field injection should not inject static fields
> -----------------------------------------------
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Task
> Components: Sling Models
> Affects Versions: Models Impl 1.4.14
> Reporter: Joerg Hoh
> Priority: Major
> Fix For: Sling Models Implementation 1.5
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
