[
https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630447#comment-17630447
]
Stefan Seifert commented on SLING-11507:
----------------------------------------
i've looked at the PR
https://github.com/apache/sling-org-apache-sling-models-api/pull/8 - lgtm!
it would also propose to fail on final fields. final fields should only be used
with constructor injection, when the field itself is managed by the model code.
> Field injection should not inject static fields
> -----------------------------------------------
>
> Key: SLING-11507
> URL: https://issues.apache.org/jira/browse/SLING-11507
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
> Affects Versions: Models Impl 1.4.14
> Reporter: Joerg Hoh
> Assignee: Dirk Rudolph
> Priority: Critical
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently this injection works:
> {noformat}
> @SlingObject
> private static ResourceResolver resourceResolver;
> {noformat}
> but it should not. Sling Models are Pojos and injection must never inject
> into static fields. Instead it should throw an exception and an error message
> indicating the problem (another option would be to refuse the injection with
> a proper error message).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
