anban02 commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#issuecomment-1346569617
I just updated the code but now that it is less code and because of the change in the IncludeTagFilter to make it call the Util-Class I don't have the mandatory 80% test coverage, because the IncludeTagFilter never had any Unit-Tests to begin with. I'll try to write some useful tests but i have never written Unit-Tests for javax.servlet.Filter implementations. Is Bertrand Delacretaz still active in this project? He seems to have done most of the implementation in that class so maybe he could give me some pointers or any other kind of help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
