anban02 commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26#discussion_r1045877563
########## src/test/java/org/apache/sling/dynamicinclude/util/RequestHelperUtilTest.java: ########## @@ -0,0 +1,143 @@ +/*- + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sling.dynamicinclude.util; + +import org.apache.sling.api.SlingHttpServletRequest; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mockito; +import org.mockito.junit.MockitoJUnitRunner; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.Map; + +@RunWith(MockitoJUnitRunner.class) +public class RequestHelperUtilTest { + + private static final String TEST_PARAM_NAME = "test-param"; + private static final String IGNORE_PARAM_REGEX_STAR_WILDCARD = "test-(.*)"; + + private SlingHttpServletRequest slingHttpServletRequest; + + @Before + public void prepareTestData() { + slingHttpServletRequest = Mockito.mock(SlingHttpServletRequest.class); + } + + @Test + public void requestHasParameters_noParametersAtAll() { + Collection<String> ignoreUrlParams = new ArrayList<>(); + + Mockito.when(slingHttpServletRequest.getParameterMap()).thenReturn(new HashMap<>()); Review Comment: Thank you. I'll improve on the points you have mentioned and then do a new push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
