cziegeler commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337171961
##########
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##########
@@ -83,23 +75,22 @@ public class LoginAdminAllowList {
cardinality = ReferenceCardinality.MULTIPLE,
policy = ReferencePolicy.DYNAMIC,
policyOption = ReferencePolicyOption.GREEDY
- ) @SuppressWarnings("unused")
+ )
void bindAllowListFragment(AllowListFragment fragment) {
allowListFragments.add(fragment);
LOG.info("AllowListFragment added '{}'", fragment);
}
- @SuppressWarnings("unused")
void unbindAllowListFragment(AllowListFragment fragment) {
allowListFragments.remove(fragment);
LOG.info("AllowListFragment removed '{}'", fragment);
}
- @Activate @Modified @SuppressWarnings("unused")
- void configure(LoginAdminAllowListConfiguration configuration, Map<String,
Object> properties) {
- this.config = new ConfigurationState(configuration);
- ensureBackwardsCompatibility(properties,
PROP_WHITELIST_BUNDLES_DEFAULT);
- ensureBackwardsCompatibility(properties,
PROP_WHITELIST_BUNDLES_ADDITIONAL);
+ @Activate @Modified
+ void configure(final LoginAdminAllowListConfiguration configuration, final
Map<String, Object> properties) {
Review Comment:
We could but we need the properties for all the methods below, so it is a
little bit easier this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
