jsedding commented on code in PR #11:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1337236451


##########
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##########
@@ -47,34 +45,28 @@
  * use the loginAdministrative method.
  */
 @Component(service = LoginAdminAllowList.class, 
-    configurationPid = LoginAdminAllowList.PID,
-    reference = {
-        // ConfigurationUpdater is a required dependency to make sure that 
configurations are
-        // updated before this component is activated
-        @Reference(
-            name = "ConfigurationUpdater",
-            service = ConfigurationUpdater.class,
-            cardinality = ReferenceCardinality.MANDATORY
-        )
-    }
-)
-@Designate(
-        ocd = LoginAdminAllowListConfiguration.class
+    configurationPid = {LoginAdminAllowList.PID, 
LoginAdminAllowList.LEGACY_PID}

Review Comment:
   That's right, yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to