adamcin commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1756120569
> From a code perspective, this looks really clean and I at least can't spot any obvious bugs. > > The challenge I'm having here is grokking the feature. While I can get what it does, the description of the change in the PR and the examples don't quite get across: > > 1. why this is helpful > 2. how as a consumer I would use this > > While we probably don't have to get this perfect before committing, I'm assuming that the PR docs will be used for the Sling website to explain the feature so I'd think we'd want to get this clarified. > > I'd suggest simplying the documentation and description, assuming your audience isn't already familiar with the feature. > > Hope that helps! @klcodanr I've edited the PR description to focus on those points. @kwin Thanks for the pointer to the site source. I'll work on a PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
