adamcin commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1758297579
@stefanseifert in reply to: > 4. you added a couple of methods to `OsgiContextImpl`. this class is the primary API class developers interact with when writing unit tests, so we should only add public methods that are useful for them in this job. it looks to me that the methods added there are only helper methods to support the junit5/4 handling of the annotations? if this is the case, the code should be moved to another class which itself interacts with `OsgiContext` to get the `ConfigurationAdmin` instance. I have addressed this point by moving all the new methods from `OsgiContextImpl` to a new `config.ConfigTypeContext` class as you recommended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
