stefanseifert commented on code in PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1354569056
########## core/src/main/java/org/apache/sling/testing/mock/osgi/config/package-info.java: ########## @@ -0,0 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ [email protected]("1.0.0") Review Comment: cosmetic: please add a package comment (for nicer javadocs) - also in the other new `package-info.java` files ########## junit5/pom.xml: ########## @@ -47,6 +47,25 @@ <classifier>tests</classifier> <scope>test</scope> </dependency> + <dependency> + <groupId>org.apache.sling</groupId> + <artifactId>org.apache.sling.testing.osgi-mock.test-services</artifactId> + <version>3.3.11-SNAPSHOT</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.sling</groupId> + <artifactId>org.apache.sling.testing.sling-mock.junit5</artifactId> Review Comment: this introduces a sort-of cyclic dependency between osgi-mock and [sling-mock][sling-mock] it would rather avoid. the only purpose seems to be the unit test `org.apache.sling.testing.mock.osgi.junit5.OsgiConfigParametersWithSlingContextExtensionTest` - i would rather move this test class to [sling-mock][sling-mock] itself? [sling-mock]: https://github.com/apache/sling-org-apache-sling-testing-sling-mock -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
