rishabhdaim commented on code in PR #18:
URL:
https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#discussion_r1574314774
##########
src/main/java/ch/qos/logback/classic/PatternLayoutOsgi.java:
##########
@@ -0,0 +1,183 @@
+/**
+ * Logback: the reliable, generic, fast and flexible logging framework.
+ * Copyright (C) 1999-2015, QOS.ch. All rights reserved.
+ *
+ * This program and the accompanying materials are dual-licensed under
+ * either the terms of the Eclipse Public License v1.0 as published by
+ * the Eclipse Foundation
+ *
+ * or (per the licensee's choosing)
+ *
+ * under the terms of the GNU Lesser General Public License version 2.1
+ * as published by the Free Software Foundation.
+ */
+package ch.qos.logback.classic;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import ch.qos.logback.classic.pattern.*;
+import ch.qos.logback.classic.pattern.color.HighlightingCompositeConverter;
+import ch.qos.logback.classic.spi.ILoggingEvent;
+import ch.qos.logback.core.CoreConstants;
+import ch.qos.logback.core.pattern.PatternLayoutBaseOsgi;
+import ch.qos.logback.core.pattern.color.*;
+import ch.qos.logback.core.pattern.parser.Parser;
+
+/**
+ * <p>
+ * A flexible layout configurable with pattern string. The goal of this class
is
+ * to {@link #format format} a {@link ILoggingEvent} and return the results in
a
+ * {#link String}. The format of the result depends on the <em>conversion
+ * pattern</em>.
+ * <p>
+ * For more information about this layout, please refer to the online manual at
+ * http://logback.qos.ch/manual/layouts.html#PatternLayout
+ *
+ */
+
+public class PatternLayoutOsgi extends PatternLayoutBaseOsgi<ILoggingEvent> {
+
+ public static final Map<String, String> DEFAULT_CONVERTER_MAP = new
HashMap<>();
Review Comment:
We should provide the estimated size to `HashMap` to avoid resizing.
##########
src/main/java/ch/qos/logback/classic/PatternLayoutOsgi.java:
##########
@@ -0,0 +1,183 @@
+/**
+ * Logback: the reliable, generic, fast and flexible logging framework.
+ * Copyright (C) 1999-2015, QOS.ch. All rights reserved.
+ *
+ * This program and the accompanying materials are dual-licensed under
+ * either the terms of the Eclipse Public License v1.0 as published by
+ * the Eclipse Foundation
+ *
+ * or (per the licensee's choosing)
+ *
+ * under the terms of the GNU Lesser General Public License version 2.1
+ * as published by the Free Software Foundation.
+ */
+package ch.qos.logback.classic;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import ch.qos.logback.classic.pattern.*;
Review Comment:
I would avoid using `*` in imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
