rombert commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2098321478
@enapps-enorman Regarding the slf4j-api - could we not also register the capability ourselves, since we provide it and bypass the serviceloader? Regarding the logback contribution - I am not sure if/how we can expedite the logback contribution. At this point I am wary of importing a large number of source files in the Sling Git repository; vendoring is not that easy and you can see on https://github.com/apache/sling-org-apache-sling-commons-json/tree/maintenance how we need to make changes and track them. I fully understand your desire to not do more work unless really required. I can think of alternative ways of approaching the logback issue, in case someone has the desire to explore them. We ended up using reflection in the Sling XSS bundle when upstream was unresponsive ( https://github.com/OWASP/java-html-sanitizer/issues/275 ) but we could also consider using Weaving Hooks ( https://docs.osgi.org/specification/osgi.core/7.0.0/framework.weavinghooks.html ) . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
