enapps-enorman commented on PR #18: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2099081961
> Regarding the slf4j-api - could we not also register the capability ourselves, since we provide it and bypass the serviceloader? It seems like that would interfere with other usages of the serviceloader so I am not inclined to spend any time on that. > At this point I am wary of importing a large number of source files in the Sling Git repository I'm not sure what you mean by a "large number" of source files? There are only 4 files under src/main/java/ch/qos/logback and only 1 of those files copies any code blocks from the original vendor. The other three extend the original classes and add to it or override to provide a different implementation. Anyways with that said, I am not interested in spending any more time on solving this in another way. If you want to do that work then please go ahead and make a proposal to prove your theory. I'm perfectly happy just managing and using my own fork at this point since I don't anticipate it needing much maintenance in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org