Hi,
On Mon, Mar 4, 2013 at 10:12 AM, Felix Meschberger <[email protected]>wrote: > Hi, > > Am 04.03.2013 um 15:10 schrieb Justin Edelson: > > > Hi, > > I might be missing something obvious, but what is the driver to put > these in a separate bundle? > > Separation of concern ? The current tag lib is about include/forward > mostly - hence request processing logic. > The new tags are around accessing resources - hence not really directly > related to request processing logic. > But including and forwarding *resources* and *scripts* both of which I would consider to be core Sling. It doesn't make sense to me to have a separate taglib than the "sling" taglib and seems like a real inconvenience to developers to have to include two different taglib directives and on deployers to deploy two separate bundles. If we had, for example, event framework-specific JSP tags, I could see those going in a separate taglib, but this stuff is at the heart of what Sling is. Regards, Justin > > Regards > Felix > > > > > Thanks, > > Justin > > > > > > On Feb 25, 2013, at 12:02 PM, Felix Meschberger <[email protected]> > wrote: > > > >> Hi Dan > >> > >> Thank you very much. Glancing over it, this looks fine -- a deeper > review is welcome. > >> > >> Yet, I wonder whether we should add those tags and EL functions to the > existing JSP taglib or whether we should create a Resource API specific tag > library ? > >> > >> WDYT ? > >> > >> Regards > >> Felix > >> > >> Am 22.02.2013 um 14:26 schrieb Dan Klco: > >> > >> All, > >> > >> I’ve made some additional contributions around the resource access > tags, based on SLING-1500<https://issues.apache.org/jira/browse/SLING-1500>, > which had some nice features including: > >> > >> • New FindResources tag, for invoking the > resourceResolver.findResources functionality > >> • Updated: GetResources tag, adds the ability to specify a base > resource under which to retrieve a relative resource > >> • New EL function adaptTo: adding the ability to adapt > adaptables in EL functions > >> • New EL function findResources: enable invoking the > resourceResolver.findResources functionality EL functions > >> • New EL function getRelativeResource: enables finding > resources by a relative path in EL functions > >> > >> The patch also contains jUnit tests for these new tags and functions. > >> > >> I was also looking through the old issues, and I believe SLING-577< > https://issues.apache.org/jira/browse/SLING-577> can be closed, as Tobias > points out you can bind a ValueMap to the page context and access > properties on it using EL functions, e.g.: > >> pageContext.setAttribute(“myProps”,aValueMap); > >> ${myProps.name} - ${myProps[‘sling:resourceType’]} > >> > >> Finally, I was wondering what the process would be for getting Sling > Taglib 2.1.9 released? Is there anything else required before it gets > released or anything I can do to help the process? > >> > >> Thanks, > >> Dan > >> > >> From: Dan Klco > >> Sent: Wednesday, December 05, 2012 3:48 PM > >> To: [email protected]<mailto:[email protected]> > >> Subject: Resource Access Tags > >> > >> All, > >> > >> I was wondering if there was any interest in adding the Resource access > tags I provided into the Sling Taglib. The idea behind these tags is to > provide a faculty for accessing some of the most common functionality in > the Sling Resource API without having to use Scriplet. > >> > >> The tags include the following: > >> • getResource – get a resource by path > >> • listChildren – invoke the listChildren method, useful if > SLING-2641 is not in place > >> • adapt – adapts adaptables to other object types > >> • getProperty – allows you to get properties from ValueMaps > with defaults and object casting > >> > >> The patches for this functionality and a page describing the Sling > TLDs, including what tags are available in each version of the Sling TLD > are on this issue: > >> https://issues.apache.org/jira/browse/SLING-2648 > >> > >> Thanks, > >> > >> Dan Klco > >> Senior Staff Engineer, Adobe WEM / Day CQ5 > >> San Ramon, CA / Dayton, OH > >> > >> <http://www.sixdimensions.com/> > >> Cell (937) 231-3050 > >> Office (937) 343-1326 > >> Fax (877) 510-5082 > >> LinkedIn<http://www.linkedin.com/in/klcodanr> | @KlcoDanR< > https://twitter.com/klcodanr> > >> > >> People. Deliver. Progress. > >> > >> > >> > >> -- > >> Felix Meschberger | Principal Scientist | Adobe > >> > >> > >> > >> > >> > >> > >> > > > > > -- > Felix Meschberger | Principal Scientist | Adobe > > > > > > > >
