Hm, I still don't think this is correct. On Mon, 2015-03-23 at 23:45 +0200, Radu Cotescu wrote: > Hi Robert, > > 1216 contains: > org.apache.sling.scripting.sightly > org.apache.sling.scripting.sightly.js.provider > org.apache.sling.scripting.sightly.repl > org.apache.sling.scripting.sightly.testing-content
Ok. > > as I've removed org.apache.sling.scripting.sightly.testing, since it was > pointing to a snapshot dependency. > > 1219 contains: > org.apache.sling.scripting.sightly.testing, which now points to > org.apache.sling.performance.base 1.0.2. Well, there are two issues here: - org.apache.sling.performance.base 1.0.2 is not released so you must not reference it yet - you've changed an artifact under vote IMO you should either drop org.apache.sling.scripting.sightly.testing completely from this release or cancel the whole release and restart the process once org.apache.sling.performance.base has been released. At any rate, it's not correct to change the artifacts under vote while the vote is running. I withdraw my vote until this issue is cleared. Robert > > Thanks, > Radu > > > > On Mon, Mar 23, 2015 at 11:37 PM, Robert Munteanu <rob...@lmn.ro> wrote: > > > On Mon, Mar 23, 2015 at 11:29 PM, Radu Cotescu <r...@apache.org> wrote: > > > Hi, > > > > > > I've started a release thread for org.apache.sling.performance.base at > > > http://sling.markmail.org/thread/m7xyhb6saxfyqs6w. > > > > > > I've also dropped org.apache.sling.scripting.sightly.testing from staging > > > repository 1216 and restaged this artifact at 1219. > > > > > > You can use this UNIX script to download the release and verify the > > > signatures for org.apache.sling.scripting.sightly.testing: > > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > > > Usage: > > > sh check_staged_release.sh 1219 /tmp/sling-staging > > > > So on which repository/artifacts are we voting now? Both 1216 and 1219 > > seem to be active. > > > > Robert > > > > > > > > Thanks, > > > Radu > > > > > > > > > On Mon, Mar 23, 2015 at 7:25 PM, Radu Cotescu <r...@apache.org> wrote: > > > > > >> Hi Robert, > > >> > > >> It would be better to release that snapshot dependency in order to > > >> provide a way to easily test Sightly artifacts. > > >> > > >> I'll take care of that this evening. > > >> > > >> Cheers, > > >> Radu > > >> > > >> > > >> On Monday, March 23, 2015, Robert Munteanu <romb...@apache.org> wrote: > > >> > > >>> On Mon, 2015-03-23 at 10:50 -0400, Daniel Klco wrote: > > >>> > org.apache.sling.sightly.testing relies on a SNAPSHOT dependency: > > >>> > > > >>> > <dependency> > > >>> > <groupId>org.apache.sling</groupId> > > >>> > > > <artifactId>org.apache.sling.performance.base</artifactId> > > >>> > <version>0.0.1-SNAPSHOT</version> > > >>> > <scope>test</scope> > > >>> > </dependency> > > >>> > > > >>> > As this is a testing project, I'm not sure if this is a big deal or > > >>> > acceptable. Ideally, if we could make a release of this performance > > >>> > tools > > >>> > it would be good to apply performance tests across all of the > > >>> > scripting > > >>> > languages available in Sling. > > >>> > > >>> Good catch! I assumed the maven release plugin would be banning > > >>> SNAPSHOTs, but apparently this is not the case ... > > >>> > > >>> We can't deploy SNAPSHOT depedencies on Maven Central and we should not > > >>> as a general rule depend on SNAPSHOTs from releases, as the SNAPSHOTs > > >>> will at some point go away and make the released artifact invalid. > > >>> > > >>> So we either release the org.apache.sling.performance.base artifact and > > >>> depend on it or drop the org.apache.sling.sightly.testing artifact from > > >>> the release. > > >>> > > >>> Radu? > > >>> > > >>> Robert > > >>> > > >>> > > >>> > > >> > > >> -- > > >> Sent with clumsy fingers from a touchscreen > > >> > > > > > > > > -- > > Sent from my (old) computer > >
