[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509000#comment-14509000
 ] 

Robert Munteanu commented on SLING-4649:
----------------------------------------

I hadn't considered that when I made the change. Looking at the code in 
LuceneIndexProviderService I can see that the {{repository.home}} property is a 
fallback in case {{localIndexDir}} is not configured

{code:java}
            String indexDirPath = 
PropertiesUtil.toString(config.get(PROP_LOCAL_INDEX_DIR), null);
            if (Strings.isNullOrEmpty(indexDirPath)) {
                String repoHome = bundleContext.getProperty(REPOSITORY_HOME);
                if (repoHome != null){
                    indexDirPath = FilenameUtils.concat(repoHome, "index");
                }
            }
{code}

What I don't understand is how the Karaf launchpad interacts with setting 
framework properties in the main launchpad. Does anything break in Karaf if we 
use framework properties? Can we simplify the Karaf launchpad/features if we 
set component properties in the main launchpad?

> FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
> ----------------------------------------------------------
>
>                 Key: SLING-4649
>                 URL: https://issues.apache.org/jira/browse/SLING-4649
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad, Oak
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>              Labels: sling-IT
>             Fix For: Launchpad Builder 8
>
>
> Failed tests: 
>   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
> condition is false after 10 seconds: A document containing 'Excepteur' is 
> found under /FullTextIndexingTest
> This last worked on Jenkins with [sling-oak-it-1.7 
> 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
> r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to