[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509364#comment-14509364
 ] 

Oliver Lietz commented on SLING-4649:
-------------------------------------

I do not fully understand your last paragraph, but I hope to make things more 
clear with some points:

* framework properties do not break anything in Karaf (Karaf in this case is 
just a wrapper/starter for Felix/Equinox like Sling's Launchpad)
* Sling works without setting any special framework properties
* framework properties cannot be added/removed/modified at runtime (AFAIK - 
[~cziegeler] knows probably better)
* when installing Sling by features in Karaf the framework (Felix) is already 
running

So not using framework properties and component configuration instead is about 
user experience. You don't have to shutdown the framework, add/change a 
property (e.g. in {{karaf/etc/custom.properties}}) and restart. You can simply 
install the required configuration when installing the Sling features in your 
running framework. It's a couplet:

{noformat}
karaf@root()> feature:repo-add 
mvn:org.apache.sling/org.apache.sling.launchpad.karaf-features/0.1.1-SNAPSHOT/xml/features
karaf@root()> feature:install sling-launchpad-oak-tar
{noformat}

And just {{sling}} for {{feature:repo-add}} when 
{{org.apache.sling.launchpad.karaf-features}} is released.

Shared configuration for {{sling-launchpad-oak-tar}} and 
{{sling-launchpad-oak-mongo}} is already in {{sling-launchpad-oak}} (main 
launchpad?) where both depend on. I don't see how to simplify further.

You can put configuration into files also, but that doesn't help here?

> FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
> ----------------------------------------------------------
>
>                 Key: SLING-4649
>                 URL: https://issues.apache.org/jira/browse/SLING-4649
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad, Oak
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>              Labels: sling-IT
>             Fix For: Launchpad Builder 8
>
>
> Failed tests: 
>   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
> condition is false after 10 seconds: A document containing 'Excepteur' is 
> found under /FullTextIndexingTest
> This last worked on Jenkins with [sling-oak-it-1.7 
> 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
> r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to