> On 14 Mar 2017, at 14:03, Stefan Seifert <[email protected]> wrote:
> 
> after the name is settled starting a new thread about the api oft he new "JCR 
> Content Parser" component [1].
> the previous implementation used a simple nested map approach for 
> representing the parsed content.
> 
> the following feedback was open:
> 1. konrad: JCR allows to have a child node and property of a node with the 
> same name.
> 2. bertrand: it would be useful to have the "getDeep" or "getByPath" method 
> directly in the API
> 
> i've create a PR for review which addresses both issues and generally 
> introduces a better separation of child nodes and properties by introducing a 
> new interface. i did not use the term "Resource" for the new hierarchy item 
> interface to avoid confusion with the Sling API. i added a getName() method 
> but not much more to keep it really simple.
> 
> please give [2] as short review from the API perspective.
I just did it. Basically it looks good, but I would be in favour of reusing the 
Resource interface from Sling API.
> 
> stefan
> 
> [1] 
> https://lists.apache.org/thread.html/8c7b540d266f975308681513f1896b45944cace4fc1eea2168cf345b@%3Cdev.sling.apache.org%3E
> [2] https://github.com/apache/sling/pull/202
> 
> 

Reply via email to