On Tue, 2017-03-14 at 14:19 +0100, Konrad Windszus wrote: > > On 14 Mar 2017, at 14:11, Stefan Seifert <[email protected]> > > wrote: > > > > > > please give [2] as short review from the API perspective. > > > > > > I just did it. Basically it looks good, but I would be in favour > > > of reusing > > > the Resource interface from Sling API. > > > > uh, this would open a can of worms because we would have to support > > all of it including ResourceResolver etc. or we leave a lot of > > methods throwing exceptions or returning null which would not be > > nice either. > > Most of the developers are familiar with that interface, and since > 80% of the methods also make sense for "offline" resources (https://s > ling.apache.org/documentation/the-sling-engine/resources.html#what- > is-a-resource) I think that would be the lesser of the two evils.
I think that to have a proper implementation of the Resource interface we also need to have a proper implementation of the ResourceResolver, which is probably non-trivial. Robert
