[
https://issues.apache.org/jira/browse/SLING-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572962#comment-16572962
]
Robert Munteanu commented on SLING-7811:
----------------------------------------
With requiring a config for {{LoginAdminWhitelist}} and setting the minimum
cardinality I still get a cancelled registration ( which is not that bad ). But
also there seem to be some runaway tasks which are not properly cancelled when
startup is cancelled, e.g.
{noformat}08.08.2018 12:46:10.372 *WARN* [oak-executor-3]
org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor Error while
dispatching observation events for
//*[11111b]@org.apache.sling.jcr.resource.internal.JcrResourceListener
java.lang.IllegalStateException: Resource resolver is already closed.
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.checkClosed(ResourceResolverImpl.java:189)
[org.apache.sling.resourceresolver:1.6.4]
at
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.getResource(ResourceResolverImpl.java:633)
[org.apache.sling.resourceresolver:1.6.4]
at
org.apache.sling.i18n.impl.JcrResourceBundleProvider.isDictionaryResource(JcrResourceBundleProvider.java:265)
[org.apache.sling.i18n:2.5.12]
at
org.apache.sling.i18n.impl.JcrResourceBundleProvider.onChange(JcrResourceBundleProvider.java:254)
[org.apache.sling.i18n:2.5.12]
at
org.apache.sling.i18n.impl.JcrResourceBundleProvider.onChange(JcrResourceBundleProvider.java:214)
[org.apache.sling.i18n:2.5.12]
at
org.apache.sling.resourceresolver.impl.observation.BasicObservationReporter.reportChanges(BasicObservationReporter.java:211)
at
org.apache.sling.jcr.resource.internal.JcrResourceListener.onEvent(JcrResourceListener.java:155)
[org.apache.sling.jcr.resource:3.0.10]
at
org.apache.jackrabbit.commons.observation.ListenerTracker$1.onEvent(ListenerTracker.java:190)
[org.apache.jackrabbit.jackrabbit-jcr-commons:2.14.4]
at
org.apache.jackrabbit.oak.jcr.observation.ChangeProcessor.contentChanged(ChangeProcessor.java:507)
[org.apache.jackrabbit.oak-jcr:1.6.8]
at
org.apache.jackrabbit.oak.plugins.observation.FilteringDispatcher.contentChanged(FilteringDispatcher.java:53)
[org.apache.jackrabbit.oak-core:1.6.8]
at
org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:134)
[org.apache.jackrabbit.oak-core:1.6.8]
at
org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:128)
[org.apache.jackrabbit.oak-core:1.6.8]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}
{noformat}08.08.2018 12:46:10.696 *ERROR* [FelixDispatchQueue]
org.apache.sling.starter.startup FrameworkEvent ERROR
(org.osgi.framework.ServiceException: Service factory returned null.
(Component: org.apache.sling.servlets.resolver.SlingServletRes
olver (268)))
org.osgi.framework.ServiceException: Service factory returned null. (Component:
org.apache.sling.servlets.resolver.SlingServletResolver (268))
at
org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:380)
at
org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:247)
at
org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
at org.apache.felix.framework.Felix.getService(Felix.java:3737)
at
org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:470)
at
org.apache.sling.starter.startup.impl.Activator.checkServices(Activator.java:146)
at
org.apache.sling.starter.startup.impl.Activator.access$100(Activator.java:32)
at
org.apache.sling.starter.startup.impl.Activator$1$1.run(Activator.java:108)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
{noformat}
In the meantime I've improved the robustness of the repository manager for
restarts and will keep debugging
* [sling-org-apache-sling-jcr-base commit
3de2b9f|https://github.com/apache/sling-org-apache-sling-jcr-base/commit/3de2b9f]
- name individual startup threads
* [sling-org-apache-sling-jcr-base commit
6f5771a|https://github.com/apache/sling-org-apache-sling-jcr-base/commit/6f5771a]
- safer shutdown
> NPE when repository is starting up
> ----------------------------------
>
> Key: SLING-7811
> URL: https://issues.apache.org/jira/browse/SLING-7811
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Oak Server 1.1.4, JCR Base 3.0.4
> Reporter: Carsten Ziegeler
> Assignee: Robert Munteanu
> Priority: Major
> Fix For: JCR Base 3.0.6, JCR Oak Server 1.2.2
>
>
> With the latest Sling Starter, the following NPE occurs in the logs. It seems
> to be harmless, nevertheless we should fix it:
> For now I assigned it to both, JCR Base and Oak Server, as it's unclear which
> one it is. Interestingly we've released Oak Server 1.2.0 but are not using it
> in the starter.
> {noformat}
> 06.08.2018 15:45:18.396 *ERROR* [Apache Sling Repository Startup Thread]
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start:
> Uncaught Throwable trying to access Repository, calling stopRepository()
> java.lang.NullPointerException: null
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192)
> [com.google.guava:15.0.0]
> at org.apache.jackrabbit.oak.jcr.Jcr.with(Jcr.java:296)
> [org.apache.jackrabbit.oak-jcr:1.6.8]
> at
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.acquireRepository(OakSlingRepositoryManager.java:161)
> [org.apache.sling.jcr.oak.server:1.1.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:471)
> [org.apache.sling.jcr.base:3.0.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:85)
> [org.apache.sling.jcr.base:3.0.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:455)
> [org.apache.sling.jcr.base:3.0.4]
> {noformat}
> The stack trace points to a null workspace name ( see
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.6.8/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/Jcr.java#L296
> ).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
