Now Jenkins build fails as well. Didn't really think of it... Any preference on how to disable this for Jenkins? Should I just check the existence of any of these environment variables: https://stackoverflow.com/a/14242750 <https://stackoverflow.com/a/14242750> or should I create a .sling-module.xml for the API module setting an explicit property via <additionalMavenParams>?
Thanks for your input, Konrad > On 7. Jan 2019, at 11:21, Konrad Windszus <[email protected]> wrote: > > Thanks for the confirmation. Always activated the profile now in > https://github.com/apache/sling-org-apache-sling-api/commit/62da4e295a799f3c784a10f23079ec2224929b1e. > >> On 7. Jan 2019, at 11:17, Carsten Ziegeler <[email protected]> wrote: >> >> I get the same error with Windows. >> >> >> Regards >> >> Carsten >> >> >> Konrad Windszus wrote >>> Can anyone check on Windows? >>> Then I would always enable that profile! >>>> On 7. Jan 2019, at 10:13, Carsten Ziegeler <[email protected]> wrote: >>>> >>>> FWIW I get the same error with Ubuntu and Java8 >>>> >>>> >>>> Regards >>>> >>>> Carsten >>>> >>>> >>>> Konrad Windszus wrote >>>>> I enforced now JDK9 or newer on Macs for Sling API in >>>>> https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 >>>>> >>>>> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640> >>>>> >>>>> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640 >>>>> >>>>> <https://github.com/apache/sling-org-apache-sling-api/commit/39a13263d46b8ffe4a749e09805e855ca80a0640>>. >>>>> We can extend to other operating systems if necessary. >>>>>> On 5. Jan 2019, at 17:23, Konrad Windszus <[email protected]> wrote: >>>>>> >>>>>> Since this does not seem to affect all cases where the IntelliJ null >>>>>> annotations are used I would recommend we enforce building with Java 9+ >>>>>> only for the Sling API part for Mac OS X for now. We can extend to other >>>>>> operating systems if this reliably fails for them as well. WDYT? >>>>>> >>>>>> >>>>>>> On 18. Dec 2018, at 17:35, Konrad Windszus <[email protected]> wrote: >>>>>>> >>>>>>> We can still put it in a dedicated profile which is only active on a >>>>>>> Mac. >>>>>>> I would volunteer to add it to the parent pom since a lot of modules >>>>>>> are affected (as the IntelliJ Null annotations are used all over the >>>>>>> place). >>>>>>> >>>>>>> Konrad >>>>>>> >>>>>>>> On 18. Dec 2018, at 17:03, Robert Munteanu <[email protected]> wrote: >>>>>>>> >>>>>>>> It's worth noting that it only affects Mac builds so far, so enforcing >>>>>>>> Java 9 might be a step too far. >>>>>>>> >>>>>>>> Robert >>>>>>>> >>>>>>>> On Tue, 2018-12-18 at 17:01 +0100, Konrad Windszus wrote: >>>>>>>>> I think due to that we should enforce building with at least Java 9. >>>>>>>>> WDYT? >>>>>>>>> >>>>>>>>>> On 18. Dec 2018, at 16:54, Konrad Windszus <[email protected]> wrote: >>>>>>>>>> >>>>>>>>>> Thanks a lot for that. Observed that as well but haven't had the >>>>>>>>>> time to investigate. I fear though that Oracle will no longer fix >>>>>>>>>> stuff in JDK 8. >>>>>>>>>> Konrad >>>>>>>>>> >>>>>>>>>>> On 18. Dec 2018, at 16:51, Radu Cotescu <[email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I’ve submitted yesterday this bug [0] to Oracle. TL;DR: one >>>>>>>>>>> cannot build the org.apache.sling.api JavaDocs with JDK 8 on >>>>>>>>>>> macOS. It all started with [1], but it’s obviously a JDK bug. >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> Radu >>>>>>>>>>> >>>>>>>>>>> [0] - >>>>>>>>>>> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8215542 >>>>>>>>>>> <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK- >>>>>>>>>>> 8215542> >>>>>>>>>>> [1] - >>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 >>>>>>>>>>> < >>>>>>>>>>> https://github.com/apache/sling-org-apache-sling-api/commit/1dccffe98b8106eea4fd1b0ef8c60baf14679ca6 >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> -- >>>> Carsten Ziegeler >>>> Adobe Research Switzerland >>>> [email protected] <mailto:[email protected]> >> -- >> Carsten Ziegeler >> Adobe Research Switzerland >> [email protected] >
