stefanseifert commented on a change in pull request #6: Added support for
simulating HTML forms (including file uploads)…
URL:
https://github.com/apache/sling-org-apache-sling-servlet-helpers/pull/6#discussion_r288742807
##########
File path:
src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletRequest.java
##########
@@ -516,6 +529,36 @@ public RequestParameterMap getRequestParameterMap() {
return params;
}
+ public void addRequestParameter(String name, String value) {
+ if (this.parameterMap.containsKey(name)) {
Review comment:
i think thats fine - just make sure to make a _separate_ commit for
reformatting, so it's not mixed up with other changes.
coding standards: i think sling roughly follows
https://felix.apache.org/documentation/development/coding-standards.html - but
that may be a bit outdated.
i think the tabs -> space conversion is the important one, not important to
reformat all other parts of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
